Provide complete API documentation coverage of scrapy.exporters #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3973 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 167 167
Lines 9705 9705
Branches 1454 1454
=======================================
Hits 8285 8285
Misses 1162 1162
Partials 258 258
|
kmike
reviewed
Aug 26, 2019
| @@ -410,3 +416,8 @@ JsonLinesItemExporter | |||
| this exporter is well suited for serializing large amounts of data. | |||
|
|
|||
| .. _JSONEncoder: https://docs.python.org/2/library/json.html#json.JSONEncoder | |||
|
|
|||
| MarshalItemExporter | |||
| ------------------- | |||
There was a problem hiding this comment.
I wonder if we should support MarshalItemExporter or deprecate it. Any idea, what is it for?
There was a problem hiding this comment.
It’s use case must be the same as PickleItemExporter’s. It should perform much better than pickle as long as its drawback are acceptable for your use case.
As to whether or not to deprecate it, I don’t mind either way.
Note that although the class was not documented, the feed export that uses it is: https://docs.scrapy.org/en/latest/topics/feed-exports.html#marshal
|
Thanks for the explanation @Gallaecio! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.