-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSONRequest naming #3982
Fix JSONRequest naming #3982
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3982 +/- ##
==========================================
+ Coverage 85.39% 85.39% +<.01%
==========================================
Files 167 167
Lines 9720 9726 +6
Branches 1455 1456 +1
==========================================
+ Hits 8300 8306 +6
Misses 1162 1162
Partials 258 258
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm fine with these changes now :)
@@ -64,7 +64,7 @@ New features | |||
provides a cleaner way to pass keyword arguments to callback methods | |||
(:issue:`1138`, :issue:`3563`) | |||
|
|||
* A new :class:`~scrapy.http.JSONRequest` class offers a more convenient way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line should be left unchanged, since the class was indeed called JSONRequest
when it was introduced in 1.7. The renaming/deprecation should be mentioned in the 1.8 release notes.
docs/news.rst
Outdated
@@ -64,7 +64,7 @@ New features | |||
provides a cleaner way to pass keyword arguments to callback methods | |||
(:issue:`1138`, :issue:`3563`) | |||
|
|||
* A new :class:`~scrapy.http.JSONRequest` class offers a more convenient way | |||
* A new :class:`~scrapy.http.JsonRequest` class offers a more convenient way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To comply with @elacuesta’s feedback while keeping a working link:
* A new :class:`~scrapy.http.JsonRequest` class offers a more convenient way | |
* A new :class:`JSONRequest <scrapy.http.JsonRequest>` class offers a more convenient way |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in local and it works, thanks 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I forgot this generated a link.
Release notes fixed |
Change
JSONRequest
toJsonRequest
to follow the same format/style as the other JSON classes (JsonLinesItemExporter
,JsonItemExporter
andJsonWriterPipeline
) and the other response/request classes (HtmlResponse
,XmlResponse
,XmlRpcRequest
)fixes: