Fix JSONRequest naming #3982
Merged
Fix JSONRequest naming #3982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3982 +/- ##
==========================================
+ Coverage 85.39% 85.39% +<.01%
==========================================
Files 167 167
Lines 9720 9726 +6
Branches 1455 1456 +1
==========================================
+ Hits 8300 8306 +6
Misses 1162 1162
Partials 258 258
|
kmike
approved these changes
Aug 28, 2019
elacuesta
reviewed
Aug 28, 2019
| @@ -64,7 +64,7 @@ New features | |||
| provides a cleaner way to pass keyword arguments to callback methods | |||
| (:issue:`1138`, :issue:`3563`) | |||
|
|
|||
| * A new :class:`~scrapy.http.JSONRequest` class offers a more convenient way | |||
There was a problem hiding this comment.
I think this line should be left unchanged, since the class was indeed called JSONRequest when it was introduced in 1.7. The renaming/deprecation should be mentioned in the 1.8 release notes.
Gallaecio
reviewed
Aug 29, 2019
docs/news.rst
Outdated
| @@ -64,7 +64,7 @@ New features | |||
| provides a cleaner way to pass keyword arguments to callback methods | |||
| (:issue:`1138`, :issue:`3563`) | |||
|
|
|||
| * A new :class:`~scrapy.http.JSONRequest` class offers a more convenient way | |||
| * A new :class:`~scrapy.http.JsonRequest` class offers a more convenient way | |||
There was a problem hiding this comment.
To comply with @elacuesta’s feedback while keeping a working link:
Suggested change
| * A new :class:`~scrapy.http.JsonRequest` class offers a more convenient way | |
| * A new :class:`JSONRequest <scrapy.http.JsonRequest>` class offers a more convenient way |
There was a problem hiding this comment.
Tested in local and it works, thanks 🙂
There was a problem hiding this comment.
Nice, I forgot this generated a link.
|
Release notes fixed |
Gallaecio
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
JSONRequesttoJsonRequestto follow the same format/style as the other JSON classes (JsonLinesItemExporter,JsonItemExporterandJsonWriterPipeline) and the other response/request classes (HtmlResponse,XmlResponse,XmlRpcRequest)fixes: