/ scrapy Public
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This patch works partially, in the sense that it prevents the reported
TypeError(I checked, for instance by adding a simple
print(request.cb_kwargs)to https://github.com/scrapy/scrapy/blob/1.7.3/scrapy/core/scheduler.py#L90, and the generated request does include a valid
cb_kwargsattribute). However, adding the
@cb_kwargscontract causes the whole callback to be excluded from the tests, and I can't for the life of me figure out why.
Update: Working now, thanks to @victor-torres