Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogFormatter improvements #3989

Merged
merged 3 commits into from Nov 19, 2019
Merged

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Aug 29, 2019

Fixes #3986

I'll add tests shortly Done

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #3989 into master will increase coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3989      +/-   ##
==========================================
+ Coverage   85.52%   85.69%   +0.16%     
==========================================
  Files         167      165       -2     
  Lines        9741     9736       -5     
  Branches     1461     1463       +2     
==========================================
+ Hits         8331     8343      +12     
+ Misses       1153     1136      -17     
  Partials      257      257
Impacted Files Coverage Δ
scrapy/core/scraper.py 89.4% <100%> (+0.07%) ⬆️
scrapy/logformatter.py 91.66% <100%> (+1.19%) ⬆️
scrapy/commands/parse.py 20.21% <0%> (-0.12%) ⬇️
scrapy/xlib/pydispatch.py
scrapy/xlib/tx.py
scrapy/item.py 98.66% <0%> (+0.11%) ⬆️
scrapy/spiders/crawl.py 82.14% <0%> (+0.43%) ⬆️
scrapy/commands/runspider.py 75.36% <0%> (+1.07%) ⬆️

@elacuesta elacuesta marked this pull request as ready for review Aug 29, 2019
@elacuesta
Copy link
Member Author

elacuesta commented Aug 31, 2019

Hold on, I will rename the method to item_error, and make the necessary changes so we can close #374 as well.

@elacuesta elacuesta changed the title Add LogFormatter.error method LogFormatter improvements Aug 31, 2019
@elacuesta elacuesta force-pushed the logformatter_error_method branch from b41693e to 27436cb Compare Sep 16, 2019
tests/test_logformatter.py Outdated Show resolved Hide resolved
wRAR
wRAR approved these changes Nov 19, 2019
@wRAR wRAR merged commit 3408b75 into scrapy:master Nov 19, 2019
2 checks passed
wRAR added a commit to wRAR/scrapy that referenced this issue Nov 19, 2019
Gallaecio pushed a commit that referenced this issue Nov 19, 2019
@elacuesta elacuesta deleted the logformatter_error_method branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants