LogFormatter improvements #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3989 +/- ##
==========================================
+ Coverage 85.52% 85.69% +0.16%
==========================================
Files 167 165 -2
Lines 9741 9736 -5
Branches 1461 1463 +2
==========================================
+ Hits 8331 8343 +12
+ Misses 1153 1136 -17
Partials 257 257
|
Gallaecio
approved these changes
Aug 29, 2019
|
Hold on, I will rename the method to |
Gallaecio
approved these changes
Sep 3, 2019
elacuesta
force-pushed
the
logformatter_error_method
branch
from
b41693e to
27436cb
Compare
kmike
reviewed
Oct 1, 2019
wRAR
approved these changes
Nov 19, 2019
wRAR
added a commit
to wRAR/scrapy
that referenced
this pull request
Nov 19, 2019
Gallaecio
pushed a commit
that referenced
this pull request
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3986
I'll add tests shortlyDone