Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errback parameter to scrapy.spiders.crawl.Rule #4000

Merged
merged 10 commits into from
Dec 18, 2019

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Sep 4, 2019

As suggested in #781 (comment).

@codecov
Copy link

codecov bot commented Sep 4, 2019

Codecov Report

Merging #4000 into master will increase coverage by 0.09%.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##           master    #4000      +/-   ##
==========================================
+ Coverage   83.86%   83.96%   +0.09%     
==========================================
  Files         165      165              
  Lines        9615     9624       +9     
  Branches     1440     1440              
==========================================
+ Hits         8064     8081      +17     
+ Misses       1304     1292      -12     
- Partials      247      251       +4
Impacted Files Coverage Δ
scrapy/spiders/crawl.py 92.47% <82.75%> (+10.33%) ⬆️

docs/topics/spiders.rst Outdated Show resolved Hide resolved
scrapy/spiders/crawl.py Show resolved Hide resolved
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
scrapy/spiders/crawl.py Outdated Show resolved Hide resolved
@wRAR wRAR merged commit 916382e into scrapy:master Dec 18, 2019
@elacuesta elacuesta deleted the rule_errback branch December 21, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants