Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated xlib module #4015

Merged
merged 1 commit into from Sep 20, 2019
Merged

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Sep 13, 2019

  • scrapy.xlib.pydispatch was deprecated in #1765 (version 1.1.0, released more than 3.5 years ago)
  • scrapy.xlib.tx was deprecated in #1887 (version 1.3.0, released almost 3 years ago)

@elacuesta elacuesta closed this Sep 13, 2019
@elacuesta elacuesta reopened this Sep 13, 2019
@codecov
Copy link

@codecov codecov bot commented Sep 13, 2019

Codecov Report

Merging #4015 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4015      +/-   ##
==========================================
+ Coverage   85.43%   85.58%   +0.14%     
==========================================
  Files         167      165       -2     
  Lines        9732     9715      -17     
  Branches     1456     1456              
==========================================
  Hits         8315     8315              
+ Misses       1159     1142      -17     
  Partials      258      258

@kmike
Copy link
Member

@kmike kmike commented Sep 20, 2019

Let's do it!

@kmike kmike merged commit 1364e92 into scrapy:master Sep 20, 2019
2 checks passed
@elacuesta elacuesta deleted the remove_deprecated_xlib branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants