Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crawling rules: make link extractors optional #4016

Merged
merged 1 commit into from Sep 20, 2019

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Sep 13, 2019

As proposed in #781

@codecov
Copy link

@codecov codecov bot commented Sep 13, 2019

Codecov Report

Merging #4016 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4016      +/-   ##
==========================================
+ Coverage   85.43%   85.44%   +<.01%     
==========================================
  Files         167      167              
  Lines        9732     9734       +2     
  Branches     1456     1456              
==========================================
+ Hits         8315     8317       +2     
  Misses       1159     1159              
  Partials      258      258
Impacted Files Coverage Δ
scrapy/spiders/crawl.py 82.14% <100%> (+0.43%) ⬆️

@elacuesta elacuesta force-pushed the rule_default_link_extractor branch from e7fb624 to 21ad8e2 Compare Sep 13, 2019
@elacuesta elacuesta closed this Sep 13, 2019
@elacuesta elacuesta reopened this Sep 13, 2019
@kmike kmike merged commit 17c0d72 into scrapy:master Sep 20, 2019
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Sep 20, 2019

Thanks @elacuesta, makes sense.

@elacuesta elacuesta deleted the rule_default_link_extractor branch Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants