Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in docs/topics/spiders #4050

Merged
merged 1 commit into from Oct 1, 2019

Conversation

KristobalJunta
Copy link
Contributor

@KristobalJunta KristobalJunta commented Oct 1, 2019

No description provided.

@codecov
Copy link

@codecov codecov bot commented Oct 1, 2019

Codecov Report

Merging #4050 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4050   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files         165      165           
  Lines        9732     9732           
  Branches     1463     1463           
=======================================
  Hits         8339     8339           
  Misses       1136     1136           
  Partials      257      257

@@ -692,7 +692,7 @@ SitemapSpider

.. method:: sitemap_filter(entries)

This is a filter funtion that could be overridden to select sitemap entries
This is a filter function that could be overridden to select sitemap entries
Copy link
Member

@elacuesta elacuesta Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest an additional change?

Suggested change
This is a filter function that could be overridden to select sitemap entries
This is a filtering function that could be overridden to select sitemap entries

Copy link
Member

@kmike kmike Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both ways of writing it look fine to me.

@kmike
Copy link
Member

@kmike kmike commented Oct 1, 2019

Merging it, as it is a clear improvement as-is.

@kmike kmike merged commit 62995e2 into scrapy:master Oct 1, 2019
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Oct 1, 2019

Thanks @KristobalJunta!

@KristobalJunta KristobalJunta deleted the fix_topics_spiders_typo branch Oct 2, 2019
@KristobalJunta
Copy link
Contributor Author

@KristobalJunta KristobalJunta commented Oct 2, 2019

@kmike you're welcome! Since I started reading scrapy code often recently, I suppose I'll be back with more PR's :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants