fix typo in docs/topics/spiders #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4050 +/- ##
=======================================
Coverage 85.68% 85.68%
=======================================
Files 165 165
Lines 9732 9732
Branches 1463 1463
=======================================
Hits 8339 8339
Misses 1136 1136
Partials 257 257 |
Gallaecio
approved these changes
Oct 1, 2019
elacuesta
reviewed
Oct 1, 2019
| @@ -692,7 +692,7 @@ SitemapSpider | |||
|
|
|||
| .. method:: sitemap_filter(entries) | |||
|
|
|||
| This is a filter funtion that could be overridden to select sitemap entries | |||
| This is a filter function that could be overridden to select sitemap entries | |||
There was a problem hiding this comment.
May I suggest an additional change?
Suggested change
| This is a filter function that could be overridden to select sitemap entries | |
| This is a filtering function that could be overridden to select sitemap entries |
There was a problem hiding this comment.
Both ways of writing it look fine to me.
|
Merging it, as it is a clear improvement as-is. |
|
Thanks @KristobalJunta! |
|
@kmike you're welcome! Since I started reading scrapy code often recently, I suppose I'll be back with more PR's :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.