Fix TypeError when using DummyStatsCollector #4052

elacuesta · 2019-10-01T15:05:36Z

Gallaecio

https://stackoverflow.com/q/11501520/939364

codecov · 2019-10-01T16:38:01Z

Codecov Report

Merging #4052 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4052      +/-   ##
==========================================
+ Coverage   85.68%   85.68%   +<.01%     
==========================================
  Files         165      165              
  Lines        9732     9734       +2     
  Branches     1463     1463              
==========================================
+ Hits         8339     8341       +2     
  Misses       1136     1136              
  Partials      257      257

Impacted Files	Coverage Δ
scrapy/extensions/corestats.py	`100% <100%> (ø)`	⬆️

kmike · 2019-10-01T18:42:14Z

tests/test_stats.py

+
+
+if __name__ == "__main__":
+    unittest_main()


this looks unnecessary, tests should be selected using py.test options. I think we should be removing this code from most files.

Sorry, tox was taking too long to run a single test 😅
I'll remove it, thanks!

You can use pytest parameters with tox, e.g. tox -e py36 -- tests/test_stats.py

tox -e py36 -- tests/test_stats.py

I use that, it takes forever anyway. I might need to read tox docs for ways to speed things up.

Oh, right, test collection does take a bit 😓

kmike · 2019-10-01T18:42:27Z

A fix looks good to me 👍

kmike

👍 +1 to squash&merge

elacuesta · 2019-10-01T21:04:19Z

Rebased and squashed

kmike · 2019-10-02T07:06:31Z

Thanks @elacuesta!

Gallaecio reviewed Oct 1, 2019

View reviewed changes

kmike reviewed Oct 1, 2019

View reviewed changes

elacuesta force-pushed the dummy_stats_collector_fix_elapsed_time branch from 32c96a5 to ed7af3d Compare October 1, 2019 19:11

kmike approved these changes Oct 1, 2019

View reviewed changes

Fix TypeError when using DummyStatsCollector

e0fabab

elacuesta force-pushed the dummy_stats_collector_fix_elapsed_time branch from ed7af3d to e0fabab Compare October 1, 2019 21:03

kmike merged commit 1650812 into scrapy:master Oct 2, 2019

elacuesta deleted the dummy_stats_collector_fix_elapsed_time branch October 2, 2019 14:10

Fix TypeError when using DummyStatsCollector #4052

Fix TypeError when using DummyStatsCollector #4052

elacuesta commented Oct 1, 2019

Gallaecio left a comment

codecov bot commented Oct 1, 2019 •

edited

kmike Oct 1, 2019

elacuesta Oct 1, 2019

Gallaecio Oct 2, 2019 •

edited

elacuesta Oct 2, 2019

Gallaecio Oct 2, 2019

kmike commented Oct 1, 2019

kmike left a comment •

edited

elacuesta commented Oct 1, 2019

kmike commented Oct 2, 2019

Fix TypeError when using DummyStatsCollector #4052

Fix TypeError when using DummyStatsCollector #4052

Conversation

elacuesta commented Oct 1, 2019

Gallaecio left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 1, 2019 • edited

Codecov Report

kmike Oct 1, 2019

Choose a reason for hiding this comment

elacuesta Oct 1, 2019

Choose a reason for hiding this comment

Gallaecio Oct 2, 2019 • edited

Choose a reason for hiding this comment

elacuesta Oct 2, 2019

Choose a reason for hiding this comment

Gallaecio Oct 2, 2019

Choose a reason for hiding this comment

kmike commented Oct 1, 2019

kmike left a comment • edited

Choose a reason for hiding this comment

elacuesta commented Oct 1, 2019

kmike commented Oct 2, 2019

codecov bot commented Oct 1, 2019 •

edited

Gallaecio Oct 2, 2019 •

edited

kmike left a comment •

edited