Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Use autoclass in topics/request-response.rst #4055

Merged

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Oct 1, 2019

As suggested in #4054 (comment), plus other wording fixes.

@codecov
Copy link

@codecov codecov bot commented Oct 2, 2019

Codecov Report

Merging #4055 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4055   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files         165      165           
  Lines        9732     9732           
  Branches     1463     1463           
=======================================
  Hits         8339     8339           
  Misses       1136     1136           
  Partials      257      257

@kmike
Copy link
Member

@kmike kmike commented Oct 2, 2019

The change looks good, but I haven't checked how it looks after the rendering. @Gallaecio if you checked it, please merge :)

@Gallaecio Gallaecio closed this Oct 2, 2019
@Gallaecio Gallaecio reopened this Oct 2, 2019
@Gallaecio Gallaecio merged commit 6ad5a89 into scrapy:master Oct 2, 2019
1 of 2 checks passed
@elacuesta elacuesta deleted the docs-autoclass-topics-request-response branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants