New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make punctuation consistent #4059
Conversation
I changed the sentence order for avoiding having the URLs with a trailing period. If you say they are valid addresses (I couldn't find the answer online, so I trust you), I don't want to trust the parser to guess right if those periods are punctuation or part of the URL. In the code of conduct, as it is written in markdown, there was no need to fix this, so I simply let the period at the end, out of the link. |
Codecov Report
@@ Coverage Diff @@
## master #4059 +/- ##
==========================================
- Coverage 85.68% 83.68% -2.01%
==========================================
Files 165 165
Lines 9734 9713 -21
Branches 1463 1445 -18
==========================================
- Hits 8341 8128 -213
- Misses 1136 1336 +200
+ Partials 257 249 -8
|
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
Sorry for the delay. I didn't know I had to commit also the suggestion, I thought you could commit it on top of the pull request. I'm not very used to GitHub's pull requests, as you can see. Thanks! |
@josealberto4444 to commit a suggestion one would need a write access to the repo, which only you have :) |
I see... Understood! =) |
Added some periods where missing in readme and code of conduct.