Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update zsh completion #4069

Merged
merged 1 commit into from
Oct 16, 2019
Merged

update zsh completion #4069

merged 1 commit into from
Oct 16, 2019

Conversation

matsievskiysv
Copy link
Contributor

Features:

  • full option completion
  • automatic project detection
  • spider name completion

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #4069 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4069   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files         165      165           
  Lines        9734     9734           
  Branches     1463     1463           
=======================================
  Hits         8341     8341           
  Misses       1136     1136           
  Partials      257      257

@Gallaecio
Copy link
Member

@Dineshs91 I know it’s been a long time since you contributed the original zsh completion, but is there any chance that you can have a look here?

VMRuiz
VMRuiz approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@VMRuiz VMRuiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No crashes and autocomplete function is pretty extensive

Gallaecio
Gallaecio approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@Gallaecio Gallaecio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s an overwhelming improvement, so +1

@kmike kmike merged commit 6674f47 into scrapy:master Oct 16, 2019
@matsievskiysv matsievskiysv mentioned this pull request Jan 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio approved these changes

@VMRuiz VMRuiz VMRuiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matsievskiysv @Gallaecio @VMRuiz @kmike