Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs of scrapy.loader.ItemLoader.item #4099

Merged
merged 1 commit into from Dec 3, 2019

Conversation

BurnzZ
Copy link
Member

@BurnzZ BurnzZ commented Oct 23, 2019

Attempts to clear up the doc misunderstanding in #3574 that results in wrong expected behavior due to incorrect usage.

Fixes #3574

@Gallaecio Gallaecio mentioned this pull request Oct 24, 2019
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #4099 into master will increase coverage by 1.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4099      +/-   ##
==========================================
+ Coverage   85.68%   86.92%   +1.23%     
==========================================
  Files         165      165              
  Lines        9734    11244    +1510     
  Branches     1463     1992     +529     
==========================================
+ Hits         8341     9774    +1433     
- Misses       1136     1206      +70     
- Partials      257      264       +7
Impacted Files Coverage Δ
scrapy/robotstxt.py 89.71% <0%> (-7.65%) ⬇️
scrapy/signalmanager.py 76% <0%> (-4.96%) ⬇️
scrapy/core/downloader/contextfactory.py 93.75% <0%> (-2.92%) ⬇️
scrapy/utils/gz.py 98.03% <0%> (-1.97%) ⬇️
scrapy/utils/spider.py 73.33% <0%> (-1.67%) ⬇️
scrapy/spiders/__init__.py 97.59% <0%> (-0.69%) ⬇️
scrapy/exporters.py 100% <0%> (ø) ⬆️
scrapy/utils/httpobj.py 100% <0%> (ø) ⬆️
scrapy/downloadermiddlewares/decompression.py 100% <0%> (ø) ⬆️
scrapy/utils/template.py 100% <0%> (ø) ⬆️
... and 57 more

@kmike kmike merged commit 9b74522 into scrapy:master Dec 3, 2019
@kmike
Copy link
Member

kmike commented Dec 3, 2019

A good idea, thanks @BurnzZ!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closed
3 participants