Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LevelDB support #4112

Merged
merged 1 commit into from Oct 31, 2019
Merged

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Oct 30, 2019

It was deprecated in 1.8 (#4092), and we should remove it now in 2.0.

@codecov
Copy link

@codecov codecov bot commented Oct 30, 2019

Codecov Report

Merging #4112 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4112      +/-   ##
==========================================
- Coverage   85.82%   85.77%   -0.06%     
==========================================
  Files         165      165              
  Lines        9851     9802      -49     
  Branches     1464     1462       -2     
==========================================
- Hits         8455     8408      -47     
+ Misses       1139     1137       -2     
  Partials      257      257
Impacted Files Coverage Δ
scrapy/extensions/httpcache.py 95.49% <ø> (-0.08%) ⬇️

wRAR
wRAR approved these changes Oct 30, 2019
@Gallaecio Gallaecio merged commit 15c55d0 into scrapy:master Oct 31, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants