Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest Python version to build the documentation #4140

Merged
merged 3 commits into from Dec 19, 2019

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 7, 2019

No description provided.

@codecov
Copy link

@codecov codecov bot commented Nov 7, 2019

Codecov Report

Merging #4140 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4140      +/-   ##
==========================================
+ Coverage   83.87%   83.96%   +0.08%     
==========================================
  Files         165      165              
  Lines        9618     9627       +9     
  Branches     1441     1441              
==========================================
+ Hits         8067     8083      +16     
+ Misses       1304     1292      -12     
- Partials      247      252       +5
Impacted Files Coverage Δ
scrapy/utils/trackref.py 82.85% <0%> (-2.86%) ⬇️
scrapy/spiders/crawl.py 92.47% <0%> (+10.33%) ⬆️

wRAR
wRAR approved these changes Nov 8, 2019
@kmike
Copy link
Member

@kmike kmike commented Nov 14, 2019

I think we need to use the same Python version as we configure on readthedocs here. Is the plan to update readthedocs to use Python 3.8 then, is it possible?

@Gallaecio
Copy link
Member Author

@Gallaecio Gallaecio commented Nov 14, 2019

Indeed, we should use the same. It seems possible.

.readthedocs.yml Show resolved Hide resolved
@wRAR wRAR merged commit c841a1f into scrapy:master Dec 19, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants