Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tutorial doctests pass #4146

Merged
merged 3 commits into from Nov 14, 2019
Merged

Make tutorial doctests pass #4146

merged 3 commits into from Nov 14, 2019

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 12, 2019

No description provided.

@codecov
Copy link

@codecov codecov bot commented Nov 13, 2019

Codecov Report

Merging #4146 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4146      +/-   ##
==========================================
+ Coverage   83.38%   83.39%   +0.01%     
==========================================
  Files         165      165              
  Lines        9801     9801              
  Branches     1463     1463              
==========================================
+ Hits         8173     8174       +1     
  Misses       1364     1364              
+ Partials      264      263       -1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 86.48% <0%> (+2.7%) ⬆️


>>> response.css('title')
[<Selector xpath='descendant-or-self::title' data='<title>Quotes to Scrape</title>'>]
.. invisible-code-block: python
Copy link
Member

@kmike kmike Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@kmike
Copy link
Member

@kmike kmike commented Nov 14, 2019

👍 👍

@kmike kmike merged commit 7b4637d into scrapy:master Nov 14, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants