Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MutableChain: return self from __iter__ #4153

Merged
merged 3 commits into from Nov 20, 2019
Merged

MutableChain: return self from __iter__ #4153

merged 3 commits into from Nov 20, 2019

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 13, 2019

@codecov
Copy link

@codecov codecov bot commented Nov 14, 2019

Codecov Report

Merging #4153 into master will increase coverage by 0.31%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #4153      +/-   ##
=========================================
+ Coverage   83.38%   83.7%   +0.31%     
=========================================
  Files         165     165              
  Lines        9801    9715      -86     
  Branches     1463    1445      -18     
=========================================
- Hits         8173    8132      -41     
+ Misses       1364    1335      -29     
+ Partials      264     248      -16
Impacted Files Coverage Δ
scrapy/utils/python.py 80.21% <100%> (+1.49%) ⬆️
scrapy/pipelines/files.py 65.9% <0%> (-0.39%) ⬇️
scrapy/pipelines/images.py 90.38% <0%> (-0.27%) ⬇️
scrapy/commands/fetch.py 89.58% <0%> (-0.22%) ⬇️
scrapy/extensions/feedexport.py 81.81% <0%> (-0.09%) ⬇️
scrapy/spidermiddlewares/referer.py 93% <0%> (-0.05%) ⬇️
scrapy/http/request/form.py 95.38% <0%> (-0.04%) ⬇️
scrapy/settings/default_settings.py 98.69% <0%> (-0.01%) ⬇️
scrapy/downloadermiddlewares/decompression.py 100% <0%> (ø) ⬆️
scrapy/downloadermiddlewares/robotstxt.py 100% <0%> (ø) ⬆️
... and 18 more

scrapy/utils/python.py Show resolved Hide resolved
@kmike kmike merged commit 65e2fb7 into scrapy:master Nov 20, 2019
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Nov 20, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants