Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the performance of the DOWNLOAD_DELAY test #4164

Merged
merged 1 commit into from Dec 18, 2019

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 14, 2019

Take the ~30s DOWNLOAD_DELAY test (see #4163) and split it in 2 ~2s tests.

@codecov
Copy link

@codecov codecov bot commented Nov 14, 2019

Codecov Report

Merging #4164 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4164      +/-   ##
==========================================
- Coverage   83.39%   83.36%   -0.04%     
==========================================
  Files         165      165              
  Lines        9801     9801              
  Branches     1463     1463              
==========================================
- Hits         8174     8171       -3     
- Misses       1364     1365       +1     
- Partials      263      265       +2
Impacted Files Coverage Δ
scrapy/utils/trackref.py 83.78% <0%> (-2.71%) ⬇️
scrapy/core/downloader/__init__.py 89.55% <0%> (-1.5%) ⬇️

wRAR
wRAR approved these changes Dec 18, 2019
@kmike kmike merged commit 3bcb14f into scrapy:master Dec 18, 2019
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Dec 18, 2019

Thanks @Gallaecio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants