Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Twisted’s deprecated HTTPClientFactory into ScrapyHTTPClientFactory #4165

Merged

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 14, 2019

Fixes one of the warnings reported at #3288

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #4165 into master will decrease coverage by 0.00%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #4165      +/-   ##
==========================================
- Coverage   84.55%   84.54%   -0.01%     
==========================================
  Files         164      164              
  Lines        9897     9926      +29     
  Branches     1480     1485       +5     
==========================================
+ Hits         8368     8392      +24     
- Misses       1261     1266       +5     
  Partials      268      268              
Impacted Files Coverage Δ
scrapy/core/downloader/webclient.py 94.48% <88.88%> (-3.48%) ⬇️

@wRAR
Copy link
Contributor

wRAR commented Nov 19, 2019

Should we mention in the source that this is a copy of some Twisted code?

wRAR
wRAR approved these changes Nov 20, 2019
nyov
nyov approved these changes Feb 28, 2020
@Gallaecio Gallaecio merged commit 792d293 into scrapy:master Aug 17, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants