Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix E711 and E713 #4167

Merged
merged 1 commit into from Nov 17, 2019
Merged

fix E711 and E713 #4167

merged 1 commit into from Nov 17, 2019

Conversation

noviluni
Copy link
Member

@noviluni noviluni commented Nov 15, 2019

Fix E711 ("Comparison to none should be 'if cond is none:'") and E713 ("Test for membership should be 'not in'")

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #4167 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4167      +/-   ##
==========================================
- Coverage   83.69%   83.68%   -0.02%     
==========================================
  Files         165      165              
  Lines        9713     9713              
  Branches     1445     1445              
==========================================
- Hits         8129     8128       -1     
  Misses       1336     1336              
- Partials      248      249       +1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 83.78% <0%> (-2.71%) ⬇️

wRAR
wRAR approved these changes Nov 17, 2019
@wRAR wRAR merged commit a78e58a into scrapy:master Nov 17, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants