Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include /requirements-py3.txt from /docs/requirements.txt #4169

Merged
merged 1 commit into from Nov 20, 2019

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 18, 2019

With #4152 I broke the documentation build, because in Read the Docs we are installing the requirements from /requirements-py3.txt, and #4152 introduced into /docs/requirements.txt a new requirement that is not installed in Read the Docs by default.

After this change, I count on fixing the Read the Docs build by changing the requirements file in Read the Docs to /docs/requirements.txt.

@codecov
Copy link

@codecov codecov bot commented Nov 18, 2019

Codecov Report

Merging #4169 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4169      +/-   ##
==========================================
+ Coverage   83.68%   83.69%   +0.01%     
==========================================
  Files         165      165              
  Lines        9713     9713              
  Branches     1445     1445              
==========================================
+ Hits         8128     8129       +1     
  Misses       1336     1336              
+ Partials      249      248       -1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 86.48% <0%> (+2.7%) ⬆️

wRAR
wRAR approved these changes Nov 18, 2019
@kmike kmike merged commit 1b4afa2 into scrapy:master Nov 20, 2019
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Nov 20, 2019

Looks good to me, thanks @Gallaecio! Would you mind updating readthedocs config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants