Include /requirements-py3.txt from /docs/requirements.txt #4169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4169 +/- ##
==========================================
+ Coverage 83.68% 83.69% +0.01%
==========================================
Files 165 165
Lines 9713 9713
Branches 1445 1445
==========================================
+ Hits 8128 8129 +1
Misses 1336 1336
+ Partials 249 248 -1
|
wRAR
approved these changes
Nov 18, 2019
|
Looks good to me, thanks @Gallaecio! Would you mind updating readthedocs config? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
With #4152 I broke the documentation build, because in Read the Docs we are installing the requirements from
/requirements-py3.txt, and #4152 introduced into/docs/requirements.txta new requirement that is not installed in Read the Docs by default.After this change, I count on fixing the Read the Docs build by changing the requirements file in Read the Docs to
/docs/requirements.txt.