Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing blank lines between functions and classes #4174

Merged
merged 1 commit into from Nov 20, 2019

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 18, 2019

Also fixed 2 unrelated Flake8 issues

Also fixed 2 unrelated Flake8 issues
@codecov
Copy link

@codecov codecov bot commented Nov 18, 2019

Codecov Report

Merging #4174 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #4174   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files         165      165           
  Lines        9713     9713           
  Branches     1445     1445           
=======================================
  Hits         8128     8128           
  Misses       1336     1336           
  Partials      249      249
Impacted Files Coverage Δ
scrapy/utils/python.py 80% <ø> (ø) ⬆️
scrapy/commands/settings.py 72.72% <ø> (ø) ⬆️
scrapy/utils/console.py 59.67% <ø> (ø) ⬆️
scrapy/resolver.py 90% <ø> (ø) ⬆️
scrapy/dupefilters.py 98.14% <ø> (ø) ⬆️
scrapy/utils/request.py 100% <ø> (ø) ⬆️
scrapy/utils/template.py 100% <ø> (ø) ⬆️
scrapy/utils/spider.py 75% <ø> (ø) ⬆️
scrapy/extensions/spiderstate.py 100% <ø> (ø) ⬆️
scrapy/utils/gz.py 96.87% <ø> (ø) ⬆️
... and 24 more

@kmike kmike merged commit e96ca89 into scrapy:master Nov 20, 2019
1 of 2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Nov 20, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants