-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Spider.make_requests_from_url method #4178
Remove deprecated Spider.make_requests_from_url method #4178
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4178 +/- ##
==========================================
- Coverage 88.09% 88.07% -0.02%
==========================================
Files 162 162
Lines 10345 10335 -10
Branches 1504 1502 -2
==========================================
- Hits 9113 9103 -10
Misses 964 964
Partials 268 268
|
Maybe deprecate it first, just in case? |
Makes sense, but just to be clear, it's not that I want to remove it. I actually think it's still valid and we might need it at some point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I guess we can leave that for a separate ticket.
8d63cdd
to
9e16c8e
Compare
9e16c8e
to
c59560a
Compare
And it hasn't been properly deprecated in Scrapy 2.0, either? 😭 I hope it might be ready for removal at the big anniversary (1.4.0 > 2.4.0), so we can close this in 2024ish? ;) |
What's the status of this? |
9846b1a
to
ec19daa
Compare
I think we should aim to remove this method 1 year after the release which contains #4412, as per https://docs.scrapy.org/en/master/versioning.html#deprecation-policy. It looks like this release was Scrapy 2.1 which happened 2020-04-24, so we should be waiting until April 2021 before merging this (assuming there is going to be a release in May). |
ec19daa
to
91f8144
Compare
As mentioned in #4170 (comment)
This method was deprecated in #1728, released in
1.4.0
Should we also remove
scrapy.utils.deprecate.method_is_overridden
? It was introduced in the above PR and it's not currently used anywhere else, but I think its purpose is still valid.Closes #4356