Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #4186

Merged
merged 3 commits into from Nov 22, 2019
Merged

Remove unused imports #4186

merged 3 commits into from Nov 22, 2019

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 21, 2019

scrapy/utils/url.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #4186 into master will decrease coverage by 0.01%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master    #4186      +/-   ##
==========================================
- Coverage   83.75%   83.73%   -0.02%     
==========================================
  Files         165      165              
  Lines        9719     9708      -11     
  Branches     1445     1445              
==========================================
- Hits         8140     8129      -11     
  Misses       1332     1332              
  Partials      247      247
Impacted Files Coverage Δ
scrapy/commands/check.py 23.18% <ø> (-2.17%) ⬇️
scrapy/selector/unified.py 100% <ø> (ø) ⬆️
scrapy/core/downloader/handlers/http.py 100% <ø> (ø) ⬆️
scrapy/core/downloader/__init__.py 90.9% <ø> (-0.14%) ⬇️
scrapy/core/downloader/handlers/s3.py 62.9% <0%> (ø) ⬆️
scrapy/utils/markup.py 100% <100%> (ø) ⬆️
scrapy/commands/view.py 58.33% <100%> (ø) ⬆️
scrapy/utils/console.py 59.67% <100%> (ø) ⬆️
scrapy/extensions/httpcache.py 95.45% <100%> (-0.04%) ⬇️
scrapy/utils/url.py 100% <100%> (ø) ⬆️
... and 8 more

wRAR
wRAR approved these changes Nov 21, 2019
tox.ini Outdated Show resolved Hide resolved
@kmike kmike merged commit 16e0636 into scrapy:master Nov 22, 2019
2 checks passed
@kmike
Copy link
Member

kmike commented Nov 22, 2019

Thanks @Gallaecio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants