LogFormatter error formatting #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4188 +/- ##
==========================================
+ Coverage 83.73% 83.73% +<.01%
==========================================
Files 165 165
Lines 9708 9722 +14
Branches 1445 1446 +1
==========================================
+ Hits 8129 8141 +12
- Misses 1332 1333 +1
- Partials 247 248 +1
|
Gallaecio
approved these changes
Nov 24, 2019
wRAR
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #374
It also fixes a small compatibility issue introduced in #3989: the simple quotes in the new message were not present in the original one.
I originally wanted to make this change as part of the above PR, I think there should be no problems with the renaming (
LogFormatter.error->LogFormatter.item_error) since that patch was not released yet.