Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogFormatter error formatting #4188

Merged
merged 4 commits into from Feb 19, 2020
Merged

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Nov 23, 2019

Fixes #374

It also fixes a small compatibility issue introduced in #3989: the simple quotes in the new message were not present in the original one.

I originally wanted to make this change as part of the above PR, I think there should be no problems with the renaming (LogFormatter.error -> LogFormatter.item_error) since that patch was not released yet.

@codecov
Copy link

@codecov codecov bot commented Nov 23, 2019

Codecov Report

Merging #4188 into master will increase coverage by <.01%.
The diff coverage is 88%.

@@            Coverage Diff             @@
##           master    #4188      +/-   ##
==========================================
+ Coverage   83.73%   83.73%   +<.01%     
==========================================
  Files         165      165              
  Lines        9708     9722      +14     
  Branches     1445     1446       +1     
==========================================
+ Hits         8129     8141      +12     
- Misses       1332     1333       +1     
- Partials      247      248       +1
Impacted Files Coverage Δ
scrapy/logformatter.py 94.59% <100%> (+2.59%) ⬆️
scrapy/core/scraper.py 88.96% <62.5%> (-0.52%) ⬇️
scrapy/utils/trackref.py 83.78% <0%> (-2.71%) ⬇️

@elacuesta elacuesta added this to the v2.0 milestone Jan 18, 2020
@kmike kmike requested a review from wRAR Feb 13, 2020
wRAR
wRAR approved these changes Feb 19, 2020
@wRAR wRAR merged commit f558df2 into scrapy:master Feb 19, 2020
2 checks passed
@elacuesta elacuesta deleted the logformatter-error-formatting branch Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants