Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use super().__init__ in BaseItemExporter subclasses #4193

Merged
merged 1 commit into from Dec 23, 2019
Merged

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 25, 2019

https://lgtm.com/rules/5990072/

This change is not necessary from a functional perspective, but instead of marking the code to be ignored, I though it may be best to switch to an implementation that allows calling super().__init__.

@codecov
Copy link

@codecov codecov bot commented Nov 25, 2019

Codecov Report

Merging #4193 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4193      +/-   ##
==========================================
+ Coverage   83.74%   83.74%   +<.01%     
==========================================
  Files         165      165              
  Lines        9713     9714       +1     
  Branches     1446     1446              
==========================================
+ Hits         8134     8135       +1     
  Misses       1332     1332              
  Partials      247      247
Impacted Files Coverage Δ
scrapy/exporters.py 100% <100%> (ø) ⬆️

@kmike
Copy link
Member

@kmike kmike commented Dec 23, 2019

Nice cleanup, thanks @Gallaecio!

@kmike kmike merged commit 4d594b8 into scrapy:master Dec 23, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants