Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep 2 spaces between code and inline comments #4195

Merged
merged 2 commits into from Dec 13, 2019

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 26, 2019

Please, pay special attention to the change to tests/test_engine.py. I’m hoping tests will pass, but even if they do, I wonder what consequences this change may have.

I also removed a class from a test file, as it did not seem used anymore.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #4195 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #4195      +/-   ##
==========================================
- Coverage   83.74%   83.73%   -0.02%     
==========================================
  Files         165      165              
  Lines        9713     9713              
  Branches     1446     1446              
==========================================
- Hits         8134     8133       -1     
  Misses       1332     1332              
- Partials      247      248       +1
Impacted Files Coverage Δ
scrapy/exporters.py 100% <ø> (ø) ⬆️
scrapy/core/downloader/webclient.py 97.97% <100%> (ø) ⬆️
scrapy/core/scraper.py 89.47% <100%> (ø) ⬆️
scrapy/core/engine.py 92.88% <100%> (ø) ⬆️
scrapy/settings/default_settings.py 98.69% <100%> (ø) ⬆️
scrapy/spiders/feed.py 66.15% <100%> (ø) ⬆️
scrapy/utils/console.py 59.67% <50%> (ø) ⬆️
scrapy/utils/trackref.py 83.78% <0%> (-2.71%) ⬇️

tests/test_engine.py Show resolved Hide resolved
@Gallaecio Gallaecio merged commit b5c4c2c into scrapy:master Dec 13, 2019
Gallaecio added a commit to Gallaecio/scrapy that referenced this pull request Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants