Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix Twisted links #4197

Merged
merged 2 commits into from Feb 7, 2020
Merged

[Docs] Fix Twisted links #4197

merged 2 commits into from Feb 7, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Nov 27, 2019

The current link for the Twisted API is not working for me when I generate the docs. There are no public links to show, since this change has not been deployed to the main docs yet.

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Nov 27, 2019

This breaks links to topics. We may need two different mappings, one for the API and one for the topics.

docs/conf.py Outdated Show resolved Hide resolved
@codecov
Copy link

@codecov codecov bot commented Nov 27, 2019

Codecov Report

Merging #4197 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4197      +/-   ##
==========================================
- Coverage   83.74%   83.73%   -0.02%     
==========================================
  Files         165      165              
  Lines        9713     9713              
  Branches     1446     1446              
==========================================
- Hits         8134     8133       -1     
  Misses       1332     1332              
- Partials      247      248       +1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 83.78% <0%> (-2.71%) ⬇️

@elacuesta elacuesta added this to the v2.0 milestone Jan 22, 2020
@kmike kmike merged commit b0eaf11 into scrapy:master Feb 7, 2020
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Feb 7, 2020

Thanks @elacuesta and @Gallaecio!

@elacuesta elacuesta deleted the sphinx-twisted-api branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants