Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the HTTPS proxy noconnect mode. #4198

Merged
merged 4 commits into from Dec 18, 2019
Merged

Conversation

wRAR
Copy link
Contributor

@wRAR wRAR commented Nov 28, 2019

This deprecates the noconnect mode for HTTPS proxies and removes related tests. As the mode was made for old Crawlera, it doesn't look like anything else needs it.

scrapy_crawlera version is important because before 1.3.0 it added '?noconnect' to all Crawlera URLs automatically.

Closes: #4187 (as not needed anymore).

@codecov
Copy link

@codecov codecov bot commented Nov 28, 2019

Codecov Report

Merging #4198 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4198      +/-   ##
==========================================
+ Coverage   83.74%   83.86%   +0.12%     
==========================================
  Files         165      165              
  Lines        9713     9618      -95     
  Branches     1446     1441       -5     
==========================================
- Hits         8134     8066      -68     
+ Misses       1332     1304      -28     
- Partials      247      248       +1
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/http11.py 92.99% <100%> (+0.08%) ⬆️
scrapy/utils/display.py 31.25% <0%> (-4.05%) ⬇️
scrapy/utils/trackref.py 82.85% <0%> (-3.63%) ⬇️
scrapy/utils/boto.py 71.42% <0%> (-3.58%) ⬇️
scrapy/extensions/memdebug.py 47.61% <0%> (-2.39%) ⬇️
scrapy/commands/list.py 77.77% <0%> (-2.23%) ⬇️
scrapy/utils/ossignal.py 73.33% <0%> (-1.67%) ⬇️
scrapy/utils/spider.py 73.91% <0%> (-1.09%) ⬇️
scrapy/signalmanager.py 80% <0%> (-0.96%) ⬇️
scrapy/commands/settings.py 71.87% <0%> (-0.86%) ⬇️
... and 61 more

tests/test_downloader_handlers.py Outdated Show resolved Hide resolved
@kmike kmike merged commit e90f276 into scrapy:master Dec 18, 2019
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Dec 18, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants