New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name resolver with IPv6 support #4227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elacuesta
reviewed
Dec 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #4227 +/- ##
==========================================
+ Coverage 84.06% 84.19% +0.12%
==========================================
Files 166 166
Lines 9730 9799 +69
Branches 1454 1467 +13
==========================================
+ Hits 8180 8250 +70
+ Misses 1296 1295 -1
Partials 254 254
|
kmike
reviewed
Jan 16, 2020
kmike
reviewed
Jan 16, 2020
kmike
reviewed
Jan 16, 2020
elacuesta
reviewed
Jan 17, 2020
kmike
reviewed
Jan 17, 2020
…attribute It's already done in the parent class
kmike
reviewed
Jan 23, 2020
Thanks @elacuesta! |
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #1031. Based on #1031 (comment).
Added the ability to enable an experimental name resolver with IPv6 support (
DNS_RESOLVER
setting, which defaults to the currentscrapy.resolver.CachingThreadedResolver
class). So far I couldn't find a "native" way to enforce a specific timeout for DNS requests, the approach in f1c1846 is not working (see https://twistedmatrix.com/trac/ticket/9748). Still, I think we can document this fact properly and give users the chance to choose, knowing the implications.To do:
Shell examples: