Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fix #4231

Merged
merged 3 commits into from Dec 16, 2019
Merged

Docs fix #4231

merged 3 commits into from Dec 16, 2019

Conversation

noviluni
Copy link
Member

@noviluni noviluni commented Dec 14, 2019

Remove reference to an old (Python 2.7) environment and update the year of the Copytight.

@codecov
Copy link

@codecov codecov bot commented Dec 14, 2019

Codecov Report

Merging #4231 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4231      +/-   ##
==========================================
+ Coverage   83.85%   83.86%   +0.01%     
==========================================
  Files         165      165              
  Lines        9615     9615              
  Branches     1440     1440              
==========================================
+ Hits         8063     8064       +1     
  Misses       1304     1304              
+ Partials      248      247       -1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 85.71% <0%> (+2.85%) ⬆️

@Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Dec 14, 2019

Should we wait 18 days to merge? :)

docs/conf.py Outdated
@@ -50,7 +50,7 @@

# General information about the project.
project = u'Scrapy'
copyright = u'2008–2018, Scrapy developers'
copyright = u'2008–2020, Scrapy developers'
Copy link
Member

@Gallaecio Gallaecio Dec 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could put the current year through code?

Copy link
Member Author

@noviluni noviluni Dec 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is definitely better. Done!

@noviluni
Copy link
Member Author

@noviluni noviluni commented Dec 15, 2019

Should we wait 18 days to merge? :)

It shouldn't be necessary now 😉

@kmike kmike merged commit e9b24d6 into scrapy:master Dec 16, 2019
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Dec 16, 2019

Thanks @noviluni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants