Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mail attachs tcmime *** (#4229) #4239

Merged
merged 1 commit into from Dec 17, 2019
Merged

Fix mail attachs tcmime *** (#4229) #4239

merged 1 commit into from Dec 17, 2019

Conversation

Apuyuseng
Copy link
Contributor

@Apuyuseng Apuyuseng commented Dec 17, 2019

When the file name consists of alphanumeric characters, it is normal to receive the attachment name.
However,However, problems will occur if the file name is changed to Chinese.
This has nothing to do with the file type

Fixes #4229

When the file name consists of alphanumeric characters, it is normal to receive the attachment name.
However,However, problems will occur if the file name is changed to Chinese.
This has nothing to do with the file type
@codecov
Copy link

@codecov codecov bot commented Dec 17, 2019

Codecov Report

Merging #4239 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #4239   +/-   ##
=======================================
  Coverage   83.86%   83.86%           
=======================================
  Files         165      165           
  Lines        9615     9615           
  Branches     1440     1440           
=======================================
  Hits         8064     8064           
  Misses       1304     1304           
  Partials      247      247
Impacted Files Coverage Δ
scrapy/mail.py 74.35% <100%> (ø) ⬆️

Copy link
Member

@Gallaecio Gallaecio left a comment

Great catch!

wRAR
wRAR approved these changes Dec 17, 2019
@wRAR wRAR merged commit 4be2bbf into scrapy:master Dec 17, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants