Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split a long test in test_engine.py into three. #4244

Merged
merged 1 commit into from Dec 18, 2019
Merged

Conversation

wRAR
Copy link
Contributor

@wRAR wRAR commented Dec 18, 2019

This helps with adding new similar tests to that class.

@codecov
Copy link

@codecov codecov bot commented Dec 18, 2019

Codecov Report

Merging #4244 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4244   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         165      165           
  Lines        9618     9618           
  Branches     1441     1441           
=======================================
  Hits         8067     8067           
  Misses       1304     1304           
  Partials      247      247

@wRAR wRAR merged commit 0e8ee22 into scrapy:master Dec 18, 2019
2 checks passed
@wRAR wRAR deleted the split-EngineTest branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants