Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #4247

Merged
merged 3 commits into from Dec 19, 2019
Merged

fix typos #4247

merged 3 commits into from Dec 19, 2019

Conversation

noviluni
Copy link
Member

@noviluni noviluni commented Dec 18, 2019

Fixed some typos in the docs.

If you prefer not to fix those in the docs/news.rst and/or those in the files under sep/ for "historical reasons" I'm agree with that, just tell me or commit.

Copy link
Member

@elacuesta elacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Personally, I have no objections to updating the news file or the seps 👌

@elacuesta
Copy link
Member

Closing and reopening to trigger a new build. The docs build is failing but I have seen the same error earlier, it seems like the server that holds https://twistedmatrix.com/documents/current/objects.inv is having some intermittent issues.

@elacuesta elacuesta closed this Dec 19, 2019
@elacuesta elacuesta reopened this Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #4247 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4247   +/-   ##
=======================================
  Coverage   83.96%   83.96%           
=======================================
  Files         165      165           
  Lines        9627     9627           
  Branches     1441     1441           
=======================================
  Hits         8083     8083           
  Misses       1292     1292           
  Partials      252      252
Impacted Files Coverage Δ
scrapy/utils/markup.py 100% <ø> (ø) ⬆️
scrapy/http/response/__init__.py 93.65% <ø> (ø) ⬆️
scrapy/utils/multipart.py 100% <ø> (ø) ⬆️
scrapy/logformatter.py 92% <ø> (ø) ⬆️
scrapy/http/response/text.py 100% <ø> (ø) ⬆️

docs/news.rst Outdated Show resolved Hide resolved
@kmike kmike merged commit 1213c0e into scrapy:master Dec 19, 2019
@kmike
Copy link
Member

kmike commented Dec 19, 2019

Thanks @noviluni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants