Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited the link provided to homepage of lxml's website #4258

Merged
merged 1 commit into from Dec 29, 2019
Merged

Edited the link provided to homepage of lxml's website #4258

merged 1 commit into from Dec 29, 2019

Conversation

atul-g
Copy link
Contributor

@atul-g atul-g commented Dec 27, 2019

The link "https://lxml.de" is redirecting to a completely different and unintended website. I changed the link to the index page of lxml's official website. I thought of changing it to the PyPi page of lxml, but even they are providing the same "https://lxml.de" link which doesn't seem to be working now.

The link "https://lxml.de" is redirecting to a completely different and unintended website. I changed the link to the index page of lxml's official website. I thought of changing it to the PyPi page of lxml, but even they are providing the same "https://lxml.de" link which doesn't seem to be working now.
@codecov
Copy link

@codecov codecov bot commented Dec 27, 2019

Codecov Report

Merging #4258 into 1.8 will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              1.8    #4258      +/-   ##
==========================================
- Coverage   85.82%   85.81%   -0.02%     
==========================================
  Files         165      165              
  Lines        9847     9847              
  Branches     1463     1463              
==========================================
- Hits         8451     8450       -1     
  Misses       1139     1139              
- Partials      257      258       +1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 83.78% <0%> (-2.71%) ⬇️

@elacuesta
Copy link
Member

@elacuesta elacuesta commented Dec 27, 2019

For reference: https://bugs.launchpad.net/lxml/+bug/1820328

@atul-g atul-g closed this Dec 28, 2019
@atul-g
Copy link
Contributor Author

@atul-g atul-g commented Dec 28, 2019

Cool, thanks for the reference.

@atul-g atul-g reopened this Dec 28, 2019
@elacuesta elacuesta changed the base branch from 1.8 to master Dec 28, 2019
@elacuesta
Copy link
Member

@elacuesta elacuesta commented Dec 28, 2019

I updated the target branch to master. The build is failing because it's based on an old branch that doesn't include the #4095 fix, I don't think we need to worry about it.

@atul-g
Copy link
Contributor Author

@atul-g atul-g commented Dec 28, 2019

Thank you for that! I'm quite new to this process of PR and still learning here. Had no idea why the build was failing when all I changed was a link.

@kmike kmike merged commit f0ae673 into scrapy:master Dec 29, 2019
0 of 2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Dec 29, 2019

Thanks @atul-g and @elacuesta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants