Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asyncio support in downloader middlewares #4259

Merged
merged 8 commits into from Jan 3, 2020
Merged

Asyncio support in downloader middlewares #4259

merged 8 commits into from Jan 3, 2020

Conversation

wRAR
Copy link
Contributor

@wRAR wRAR commented Dec 30, 2019

No description provided.

@codecov
Copy link

@codecov codecov bot commented Dec 30, 2019

Codecov Report

Merging #4259 into master will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #4259     +/-   ##
=========================================
+ Coverage   83.88%   84.09%   +0.2%     
=========================================
  Files         166      166             
  Lines        9709     9730     +21     
  Branches     1450     1454      +4     
=========================================
+ Hits         8144     8182     +38     
+ Misses       1313     1295     -18     
- Partials      252      253      +1
Impacted Files Coverage Δ
scrapy/utils/test.py 58.33% <100%> (+4.62%) ⬆️
scrapy/utils/defer.py 97.29% <100%> (+0.68%) ⬆️
scrapy/core/downloader/middleware.py 100% <100%> (ø) ⬆️
scrapy/utils/trackref.py 82.85% <0%> (-2.86%) ⬇️
scrapy/robotstxt.py 97.53% <0%> (+22.22%) ⬆️

.travis.yml Show resolved Hide resolved
kmike
kmike approved these changes Jan 3, 2020
Copy link
Member

@kmike kmike left a comment

Other than CI setup, it looks good to me, thanks @wRAR!

@kmike kmike merged commit ce618fb into master Jan 3, 2020
2 checks passed
@wRAR wRAR added the asyncio label Aug 17, 2021
@wRAR wRAR deleted the asyncio-mw branch Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants