Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async def support in pipelines #4270

Merged
merged 6 commits into from Jan 15, 2020
Merged

async def support in pipelines #4270

merged 6 commits into from Jan 15, 2020

Conversation

wRAR
Copy link
Contributor

@wRAR wRAR commented Jan 9, 2020

No description provided.

@codecov
Copy link

@codecov codecov bot commented Jan 9, 2020

Codecov Report

Merging #4270 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4270      +/-   ##
==========================================
+ Coverage   84.06%   84.09%   +0.02%     
==========================================
  Files         166      166              
  Lines        9730     9737       +7     
  Branches     1454     1454              
==========================================
+ Hits         8180     8188       +8     
  Misses       1296     1296              
+ Partials      254      253       -1
Impacted Files Coverage Δ
scrapy/utils/defer.py 97.5% <100%> (+0.2%) ⬆️
scrapy/pipelines/__init__.py 92.85% <100%> (+0.54%) ⬆️
scrapy/utils/trackref.py 85.71% <0%> (+2.85%) ⬆️

@@ -2,6 +2,7 @@
Helper functions for dealing with Twisted deferreds
"""
import asyncio
from functools import wraps
Copy link
Member

@Gallaecio Gallaecio Jan 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄 Below import inspect?

Copy link
Member

@kmike kmike Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like @Gallaecio's style proposal a bit more than what's in the code. Merging PR anyways, this is not a blocker.

@kmike
Copy link
Member

@kmike kmike commented Jan 15, 2020

Thanks @wRAR!

@kmike kmike merged commit 50310fc into scrapy:master Jan 15, 2020
2 checks passed
@wRAR wRAR added the asyncio label Aug 17, 2021
@wRAR wRAR deleted the asyncio-pipelines branch Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants