Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix variable name author_page_links #4286

Merged
merged 1 commit into from Jan 27, 2020

Conversation

petervandenabeele
Copy link
Contributor

@petervandenabeele petervandenabeele commented Jan 25, 2020

I did not test this code, but the change from href to this
author_page_links seems to have a typo ?

I did not test this code, but the change from `href` to this
author_page_links seems to have a typo ?
@petervandenabeele petervandenabeele changed the title Fix variable name author_page_links [documentation] Fix variable name author_page_links Jan 25, 2020
@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #4286 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4286      +/-   ##
==========================================
- Coverage   83.91%   83.88%   -0.04%     
==========================================
  Files         166      166              
  Lines        9869     9869              
  Branches     1469     1469              
==========================================
- Hits         8282     8279       -3     
- Misses       1334     1335       +1     
- Partials      253      255       +2
Impacted Files Coverage Δ
scrapy/utils/trackref.py 82.85% <0%> (-2.86%) ⬇️
scrapy/core/downloader/__init__.py 89.31% <0%> (-1.53%) ⬇️

@petervandenabeele petervandenabeele changed the title [documentation] Fix variable name author_page_links [docs] Fix variable name author_page_links Jan 26, 2020
@petervandenabeele petervandenabeele changed the title [docs] Fix variable name author_page_links [Docs] Fix variable name author_page_links Jan 26, 2020
Copy link
Member

@elacuesta elacuesta left a comment

Good catch, thanks!

@kmike kmike merged commit a6bf895 into scrapy:master Jan 27, 2020
2 checks passed
@kmike
Copy link
Member

kmike commented Jan 27, 2020

Thanks @petervandenabeele!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants