Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zsh -h autocomplete option #4291

Merged
merged 1 commit into from Feb 7, 2020
Merged

add zsh -h autocomplete option #4291

merged 1 commit into from Feb 7, 2020

Conversation

matsievskiysv
Copy link
Contributor

@matsievskiysv matsievskiysv commented Jan 27, 2020

This PR adds autocompletion for -h option for zsh.
This option was not added to #4069 due to the problem described in this so question.

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #4291 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4291      +/-   ##
==========================================
- Coverage   83.91%   83.68%   -0.24%     
==========================================
  Files         166      166              
  Lines        9869     9869              
  Branches     1469     1469              
==========================================
- Hits         8282     8259      -23     
- Misses       1334     1354      +20     
- Partials      253      256       +3
Impacted Files Coverage Δ
scrapy/robotstxt.py 75.3% <0%> (-22.23%) ⬇️
scrapy/utils/trackref.py 82.85% <0%> (-2.86%) ⬇️
scrapy/utils/defer.py 95% <0%> (-2.5%) ⬇️
scrapy/core/downloader/__init__.py 89.31% <0%> (-1.53%) ⬇️

@kmike kmike merged commit 7e341e0 into scrapy:master Feb 7, 2020
2 checks passed
@kmike
Copy link
Member

kmike commented Feb 7, 2020

I'm not a zsh user myself, but hope this works :P

matsievskiysv pushed a commit to matsievskiysv/scrapy that referenced this pull request Mar 17, 2020
- Fix bug introduced in scrapy#4291
- Enforce `[command] [options] [arguments]` syntax. Do not allow options after arguments
- Exclude already used option aliases from completion list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants