Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpCompressionMiddleware] fix delimiter for Accept-Encoding header #4293

Merged
merged 1 commit into from Jan 29, 2020

Conversation

Verz1Lka
Copy link
Contributor

@Verz1Lka Verz1Lka commented Jan 29, 2020

Accept-Encoding header should have , (with space) as a delimiter between encodings instead of , (non space) (https://tools.ietf.org/html/rfc2616#section-14.3)

@Verz1Lka Verz1Lka requested a review from kmike Jan 29, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 29, 2020

Codecov Report

Merging #4293 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4293      +/-   ##
==========================================
- Coverage   83.91%   83.89%   -0.03%     
==========================================
  Files         166      166              
  Lines        9869     9869              
  Branches     1469     1469              
==========================================
- Hits         8282     8280       -2     
- Misses       1334     1335       +1     
- Partials      253      254       +1
Impacted Files Coverage Δ
scrapy/downloadermiddlewares/httpcompression.py 89.13% <ø> (ø) ⬆️
scrapy/core/downloader/__init__.py 89.31% <0%> (-1.53%) ⬇️

kmike
kmike approved these changes Jan 29, 2020
Copy link
Member

@kmike kmike left a comment

Looks good, thanks @edorofeev!

@dangra
Copy link
Member

@dangra dangra commented Jan 29, 2020

+1 LGTM.

@kmike kmike merged commit 534ce07 into scrapy:master Jan 29, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants