Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request_left_downloader signal #4303

Merged
merged 13 commits into from Feb 7, 2020

Conversation

whalebot-helmsman
Copy link
Contributor

@whalebot-helmsman whalebot-helmsman commented Feb 5, 2020

As requested in #3520 (comment) (cc @elacuesta )

@codecov
Copy link

@codecov codecov bot commented Feb 5, 2020

Codecov Report

Merging #4303 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4303      +/-   ##
==========================================
+ Coverage   83.93%   83.94%   +0.01%     
==========================================
  Files         166      165       -1     
  Lines        9870     9883      +13     
  Branches     1469     1470       +1     
==========================================
+ Hits         8284     8296      +12     
- Misses       1333     1334       +1     
  Partials      253      253
Impacted Files Coverage Δ
scrapy/signals.py 100% <100%> (ø) ⬆️
scrapy/core/downloader/__init__.py 89.39% <100%> (-1.45%) ⬇️
scrapy/utils/log.py 88.76% <0%> (-0.13%) ⬇️
scrapy/crawler.py 89.26% <0%> (ø) ⬆️
scrapy/settings/default_settings.py 98.71% <0%> (ø) ⬆️
scrapy/utils/asyncio.py
scrapy/utils/trackref.py 85.71% <0%> (+2.85%) ⬆️
scrapy/utils/reactor.py 83.33% <0%> (+11.45%) ⬆️

docs/topics/signals.rst Outdated Show resolved Hide resolved
docs/topics/signals.rst Outdated Show resolved Hide resolved
tests/test_request_left.py Outdated Show resolved Hide resolved
@elacuesta
Copy link
Member

@elacuesta elacuesta commented Feb 5, 2020

Thanks @whalebot-helmsman! Code looks great, just I left a few stylistic comments.

tests/test_request_left.py Outdated Show resolved Hide resolved
whalebot-helmsman and others added 4 commits Feb 6, 2020
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
…helmsman/scrapy into request_left_downloader_signal
docs/topics/signals.rst Outdated Show resolved Hide resolved
docs/topics/signals.rst Outdated Show resolved Hide resolved
docs/topics/signals.rst Outdated Show resolved Hide resolved
whalebot-helmsman and others added 4 commits Feb 7, 2020
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
Co-Authored-By: Adrián Chaves <adrian@chaves.io>
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
@kmike kmike merged commit afbaf9d into scrapy:master Feb 7, 2020
2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Feb 7, 2020

Thanks @whalebot-helmsman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants