Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions regarding Python 3 and virtual environments #4309

Merged
merged 1 commit into from Feb 18, 2020

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Feb 6, 2020

Simplify by not repeating information that can be found in upstream, linked documentation.

Fixes #4001, closes #4101

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #4309 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4309   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files         165      165           
  Lines        9893     9893           
  Branches     1469     1469           
=======================================
  Hits         8306     8306           
  Misses       1334     1334           
  Partials      253      253

docs/intro/install.rst Outdated Show resolved Hide resolved
docs/intro/install.rst Outdated Show resolved Hide resolved
docs/intro/install.rst Outdated Show resolved Hide resolved
docs/intro/install.rst Outdated Show resolved Hide resolved
docs/intro/install.rst Outdated Show resolved Hide resolved
@Gallaecio
Copy link
Member Author

Gallaecio commented Feb 7, 2020

I better rewrite the patch focusing on the virtual environment changes only.

@Gallaecio Gallaecio changed the title Rewrite the installation instructions Update installation instructions regarding Python 3 and virtual environments Feb 7, 2020
To get started with virtual environments, see `virtualenv installation instructions`_.
To install it globally (having it globally installed actually helps here),
it should be a matter of running::
See :ref:`tut-venv` on how to create your virtual environment.
Copy link
Member Author

@Gallaecio Gallaecio Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmike kmike merged commit 320cea6 into scrapy:master Feb 18, 2020
2 checks passed
@kmike
Copy link
Member

kmike commented Feb 18, 2020

Thanks @Gallaecio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite the virtual environment documentation section for Python-3-only Scrapy
2 participants