Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Response.cb_kwargs #4331

Merged
merged 5 commits into from Feb 19, 2020
Merged

Implement Response.cb_kwargs #4331

merged 5 commits into from Feb 19, 2020

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Feb 13, 2020

No description provided.

@codecov
Copy link

@codecov codecov bot commented Feb 13, 2020

Codecov Report

Merging #4331 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4331      +/-   ##
==========================================
- Coverage   83.85%   83.79%   -0.06%     
==========================================
  Files         165      165              
  Lines        9615     9913     +298     
  Branches     1440     1472      +32     
==========================================
+ Hits         8063     8307     +244     
- Misses       1304     1351      +47     
- Partials      248      255       +7
Impacted Files Coverage Δ
scrapy/http/response/__init__.py 97.29% <100%> (+3.64%) ⬆️
scrapy/robotstxt.py 75.3% <0%> (-22.23%) ⬇️
scrapy/utils/ftp.py 23.8% <0%> (-6.2%) ⬇️
scrapy/utils/test.py 49.35% <0%> (-4.36%) ⬇️
scrapy/pipelines/files.py 61.66% <0%> (-3.99%) ⬇️
scrapy/core/downloader/__init__.py 89.39% <0%> (-1.45%) ⬇️
scrapy/utils/defer.py 95.65% <0%> (-0.84%) ⬇️
scrapy/core/downloader/handlers/datauri.py 93.33% <0%> (-0.79%) ⬇️
scrapy/crawler.py 89.26% <0%> (-0.68%) ⬇️
scrapy/utils/python.py 80.1% <0%> (ø) ⬆️
... and 31 more

docs/topics/request-response.rst Outdated Show resolved Hide resolved
Gallaecio and others added 2 commits Feb 14, 2020
Co-Authored-By: elacuesta <elacuesta@users.noreply.github.com>
@Gallaecio Gallaecio mentioned this pull request Feb 14, 2020
wRAR
wRAR approved these changes Feb 19, 2020
@wRAR wRAR merged commit 8817902 into scrapy:master Feb 19, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants