Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.rst #4335

Merged
merged 4 commits into from
Jan 21, 2022
Merged

Update install.rst #4335

merged 4 commits into from
Jan 21, 2022

Conversation

leobalestri
Copy link
Contributor

Minor grammar and typo fixes

Minor grammar and typo fixes
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #4335 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4335      +/-   ##
==========================================
- Coverage   84.16%   84.15%   -0.02%     
==========================================
  Files         166      166              
  Lines        9970     9970              
  Branches     1483     1483              
==========================================
- Hits         8391     8390       -1     
  Misses       1324     1324              
- Partials      255      256       +1
Impacted Files Coverage Δ
scrapy/utils/trackref.py 82.85% <0%> (-2.86%) ⬇️

docs/intro/install.rst Outdated Show resolved Hide resolved
@kmike kmike changed the base branch from 1.8 to master February 28, 2020 19:38
@kmike
Copy link
Member

kmike commented Feb 28, 2020

Hey! I've noticed that this PR is against 1.8, but the same typos are present in master, so I changed the base - but now there are merge conflicts. +1 to merge after resolving them.

@wRAR wRAR merged commit 169bc88 into scrapy:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants