Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated scrapy/docs/topics/request-response.rst #4332 #4338

Merged
merged 4 commits into from Feb 18, 2020

Conversation

akshaysharmajs
Copy link
Contributor

@akshaysharmajs akshaysharmajs commented Feb 17, 2020

changed ie. -> i.e.(spelling error) on lines 667, 763 (issue #4332)

@akshaysharmajs akshaysharmajs changed the title Updated scrapy/docs/topics/request-response.rst Updated scrapy/docs/topics/request-response.rst #4332 Feb 17, 2020
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #4338 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4338      +/-   ##
==========================================
- Coverage   83.97%   83.94%   -0.04%     
==========================================
  Files         165      165              
  Lines        9907     9907              
  Branches     1472     1472              
==========================================
- Hits         8319     8316       -3     
- Misses       1334     1336       +2     
- Partials      254      255       +1
Impacted Files Coverage Δ
scrapy/utils/spider.py 75% <ø> (ø) ⬆️
scrapy/utils/request.py 100% <ø> (ø) ⬆️
scrapy/shell.py 68.61% <ø> (ø) ⬆️
scrapy/utils/misc.py 95.19% <ø> (-1.93%) ⬇️
scrapy/utils/defer.py 93.47% <0%> (-2.18%) ⬇️
scrapy/utils/trackref.py 85.71% <0%> (+2.85%) ⬆️

@Gallaecio
Copy link
Member

Gallaecio commented Feb 17, 2020

Would you mind using this pull request to fix the issue in all files, instead of a single file? You can add more commits to your branch as needed.

@akshaysharmajs
Copy link
Contributor Author

akshaysharmajs commented Feb 17, 2020

Would you mind using this pull request to fix the issue in all files, instead of a single file? You can add more commits to your branch as needed.

I have changed all text files for the issue as mentioned above. 👍

@Gallaecio Gallaecio merged commit 182445f into scrapy:master Feb 18, 2020
2 checks passed
@Gallaecio
Copy link
Member

Gallaecio commented Feb 18, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants