New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed "Debugging memory leaks with Guppy"( issue #4285) #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@noviluni please review |
Gallaecio
approved these changes
Feb 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #4343 +/- ##
==========================================
+ Coverage 84.75% 84.78% +0.02%
==========================================
Files 165 164 -1
Lines 9898 9883 -15
Branches 1470 1469 -1
==========================================
- Hits 8389 8379 -10
+ Misses 1253 1248 -5
Partials 256 256
|
noviluni
approved these changes
Feb 19, 2020
Hi @Gallaecio I've seen that after removing this we should probably delete these lines:
from the Do you agree? |
noviluni
approved these changes
Feb 19, 2020
Gallaecio
reviewed
Feb 19, 2020
updating my fork
wRAR
approved these changes
Mar 16, 2020
@sakshamb2113 can you please update this to resolve the conflict? |
sure |
@wRAR what should we do about the "hpy" key of telnet_vars in telnet.py ? |
Gallaecio
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The section referring to guppy(for python 2.7) for debugging memory leaks now only refers to muppy(for python 3). Issue #4285.