Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "Debugging memory leaks with Guppy"( issue #4285) #4343

Merged
merged 8 commits into from Mar 17, 2020

Conversation

sakshamb2113
Copy link
Contributor

@sakshamb2113 sakshamb2113 commented Feb 18, 2020

The section referring to guppy(for python 2.7) for debugging memory leaks now only refers to muppy(for python 3). Issue #4285.

@sakshamb2113
Copy link
Contributor Author

@sakshamb2113 sakshamb2113 commented Feb 18, 2020

@noviluni please review

@codecov
Copy link

@codecov codecov bot commented Feb 19, 2020

Codecov Report

Merging #4343 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4343      +/-   ##
==========================================
+ Coverage   84.75%   84.78%   +0.02%     
==========================================
  Files         165      164       -1     
  Lines        9898     9883      -15     
  Branches     1470     1469       -1     
==========================================
- Hits         8389     8379      -10     
+ Misses       1253     1248       -5     
  Partials      256      256
Impacted Files Coverage Δ
scrapy/extensions/telnet.py 81.66% <ø> (+0.12%) ⬆️
scrapy/utils/trackref.py 82.85% <0%> (ø) ⬆️
scrapy/downloadermiddlewares/chunked.py

@noviluni
Copy link
Member

@noviluni noviluni commented Feb 19, 2020

Hi @Gallaecio

I've seen that after removing this we should probably delete these lines:

try:
    import guppy
    hpy = guppy.hpy()
except ImportError:
    hpy = None

from the scrapy/extensions/telnet.py.

Do you agree?

scrapy/extensions/telnet.py Outdated Show resolved Hide resolved
wRAR
wRAR approved these changes Mar 16, 2020
@wRAR
Copy link
Contributor

@wRAR wRAR commented Mar 16, 2020

@sakshamb2113 can you please update this to resolve the conflict?

@sakshamb2113
Copy link
Contributor Author

@sakshamb2113 sakshamb2113 commented Mar 16, 2020

sure

@sakshamb2113
Copy link
Contributor Author

@sakshamb2113 sakshamb2113 commented Mar 16, 2020

@wRAR what should we do about the "hpy" key of telnet_vars in telnet.py ?

Copy link
Member

@Gallaecio Gallaecio left a comment

Pending one small change.

@Gallaecio Gallaecio merged commit 533131a into scrapy:master Mar 17, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants