Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated sel shortcut in scrapy shell #4347

Merged
merged 2 commits into from Feb 19, 2020

Conversation

noviluni
Copy link
Member

It was 6 years ago when this deprecation warning was added, before Scrapy 1.0 was released.

Could we remove it when releasing the new Scrapy 2.0 version?

@noviluni
Copy link
Member Author

There are some other deprecation warnings that could be removed in the new version. Let me know what you think about it and I will create another PR with the other deprecations.

@noviluni noviluni changed the title deprecare sel shortcut in scrapy shell deprecate sel shortcut in scrapy shell Feb 19, 2020
@elacuesta elacuesta changed the title deprecate sel shortcut in scrapy shell Remove deprecated sel shortcut in scrapy shell Feb 19, 2020
@elacuesta
Copy link
Member

Looks good to me, thanks 👍
For reference, the shortcut was deprecated in #690.
I'll approve once the Flake8 issues are solved

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #4347 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4347      +/-   ##
==========================================
+ Coverage   83.91%   84.09%   +0.17%     
==========================================
  Files         166      165       -1     
  Lines        9869     9970     +101     
  Branches     1469     1491      +22     
==========================================
+ Hits         8282     8384     +102     
+ Misses       1334     1333       -1     
  Partials      253      253
Impacted Files Coverage Δ
scrapy/shell.py 68.21% <100%> (-0.4%) ⬇️
scrapy/utils/trackref.py 82.85% <0%> (-2.86%) ⬇️
scrapy/utils/defer.py 95.65% <0%> (-1.85%) ⬇️
scrapy/utils/log.py 88.76% <0%> (-0.13%) ⬇️
scrapy/utils/python.py 80.1% <0%> (ø) ⬆️
scrapy/http/response/text.py 100% <0%> (ø) ⬆️
scrapy/core/spidermw.py 100% <0%> (ø) ⬆️
scrapy/crawler.py 89.26% <0%> (ø) ⬆️
scrapy/signals.py 100% <0%> (ø) ⬆️
scrapy/settings/default_settings.py 98.71% <0%> (ø) ⬆️
... and 10 more

@kmike
Copy link
Member

kmike commented Feb 19, 2020

6 years passed 😱 This looks good, +1 to merge after fixing flake8 error.

@Gallaecio Gallaecio closed this Feb 19, 2020
@Gallaecio Gallaecio reopened this Feb 19, 2020
@kmike kmike merged commit c4ee4b6 into scrapy:master Feb 19, 2020
@noviluni
Copy link
Member Author

Thank you @Gallaecio for fixing the flake8 errors 😅

I opened a new issue with some old deprecation warnings to see if you have any inconvenience in adressing them: #4356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants