Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix E30X flake8 #4355

Merged
merged 1 commit into from Feb 21, 2020
Merged

fix E30X flake8 #4355

merged 1 commit into from Feb 21, 2020

Conversation

noviluni
Copy link
Member

@noviluni noviluni commented Feb 20, 2020

This PR fixes all the exceptions to the E30X rules of flake8:

  • E301: Expected 1 blank line, found 0 --> 1 case
  • E302: Expected 2 blank lines, found 0 --> 0 cases
  • E303: Too many blank lines --> 12 cases
  • E304: Blank lines found after function decorator --> 0 cases
  • E305: Expected 2 blank lines after end of function or class --> 16 cases
  • E306: Expected 1 blank line before a nested definition --> 11 cases

@codecov
Copy link

@codecov codecov bot commented Feb 20, 2020

Codecov Report

Merging #4355 into master will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4355      +/-   ##
==========================================
- Coverage   83.96%   83.77%   -0.19%     
==========================================
  Files         165      165              
  Lines        9919     9919              
  Branches     1473     1473              
==========================================
- Hits         8328     8310      -18     
- Misses       1334     1352      +18     
  Partials      257      257
Impacted Files Coverage Δ
scrapy/responsetypes.py 94.11% <ø> (ø) ⬆️
scrapy/utils/console.py 59.67% <ø> (ø) ⬆️
scrapy/core/engine.py 92.88% <ø> (ø) ⬆️
scrapy/utils/gz.py 96.87% <ø> (ø) ⬆️
scrapy/core/downloader/tls.py 86.04% <ø> (ø) ⬆️
scrapy/robotstxt.py 75.3% <0%> (-22.23%) ⬇️

Copy link
Member

@elacuesta elacuesta left a comment

🚀

@Gallaecio Gallaecio merged commit 91bbc70 into scrapy:master Feb 21, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants