Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix E22X flake8 #4360

Merged
merged 1 commit into from Feb 21, 2020
Merged

fix E22X flake8 #4360

merged 1 commit into from Feb 21, 2020

Conversation

noviluni
Copy link
Member

@noviluni noviluni commented Feb 21, 2020

This PR fixes all the exceptions to the E22X rules of flake8:

  • E221: Multiple spaces before operator → 1 affected files
  • E222: Multiple spaces after operator → 0 affected files
  • E223: Tab before operator → 0 affected files
  • E224: Tab after operator → 0 affected files
  • E225: Missing whitespace around operator → 2 affected files
  • E226: Missing whitespace around arithmetic operator → 22 affected files
  • E227: Missing whitespace around bitwise or shift operator → 0 affected files
  • E228: Missing whitespace around modulo operator → 0 affected files

@codecov
Copy link

@codecov codecov bot commented Feb 21, 2020

Codecov Report

Merging #4360 into master will decrease coverage by 0.23%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##           master    #4360      +/-   ##
==========================================
- Coverage   84.01%   83.77%   -0.24%     
==========================================
  Files         165      165              
  Lines        9919     9919              
  Branches     1473     1473              
==========================================
- Hits         8333     8310      -23     
- Misses       1332     1352      +20     
- Partials      254      257       +3
Impacted Files Coverage Δ
scrapy/spiderloader.py 100% <ø> (ø) ⬆️
scrapy/commands/parse.py 20.21% <0%> (ø) ⬆️
scrapy/utils/datatypes.py 66.46% <0%> (ø) ⬆️
scrapy/utils/reactor.py 83.33% <0%> (ø) ⬆️
scrapy/downloadermiddlewares/ajaxcrawl.py 95% <100%> (ø) ⬆️
scrapy/core/downloader/webclient.py 97.97% <100%> (ø) ⬆️
scrapy/utils/misc.py 95.19% <100%> (-1.93%) ⬇️
scrapy/core/spidermw.py 100% <100%> (ø) ⬆️
scrapy/exporters.py 100% <100%> (ø) ⬆️
scrapy/utils/http.py 93.75% <100%> (ø) ⬆️
... and 6 more

@kmike kmike merged commit b0a7efb into scrapy:master Feb 21, 2020
1 of 2 checks passed
@kmike
Copy link
Member

@kmike kmike commented Feb 21, 2020

Thanks @noviluni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants