Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete old deprecated functions from scrapy.utils.python #4362

Merged
merged 1 commit into from Feb 21, 2020

Conversation

noviluni
Copy link
Member

Hi there!

I deleted 4 deprecated functions from scrapy.utils.python (as mentioned here: #4356), the deprecation warnings were added in 07/2015 for three of them and in 03/2016 for the other.

As they are in the same file I decided to do just one PR, but if you prefer I can separate them in different PRs. There are two more deprecated functions in this file but as they were deprecated in 2019 I decided not to change them. Let me know what you think. 馃檪

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #4362 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4362      +/-   ##
==========================================
+ Coverage   84.01%   84.12%   +0.11%     
==========================================
  Files         165      165              
  Lines        9919     9897      -22     
  Branches     1473     1469       -4     
==========================================
- Hits         8333     8326       -7     
+ Misses       1332     1318      -14     
+ Partials      254      253       -1
Impacted Files Coverage 螖
scrapy/utils/python.py 85.36% <酶> (+5.25%) 猬嗭笍
scrapy/robotstxt.py 97.53% <0%> (酶) 猬嗭笍
scrapy/core/downloader/__init__.py 90.9% <0%> (+1.51%) 猬嗭笍

Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@kmike kmike merged commit 1be1101 into scrapy:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants